Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using self contained guardian package #5212

Merged
merged 1 commit into from
Apr 7, 2020
Merged

using self contained guardian package #5212

merged 1 commit into from
Apr 7, 2020

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Apr 6, 2020

Fixes #5168

@markwilkie
Copy link
Member

Thanks for doing this @Anipik

Look good to you @sunandabalu ?

@Anipik Anipik closed this Apr 7, 2020
@Anipik Anipik reopened this Apr 7, 2020
@sunandabalu
Copy link
Member

The change itself looks fine to me, but I would like to see some test runs with the change to make sure it does not break anyone. I know @Anipik ran this change through runtime, @Anipik could you kick off an arcade run with this change just to be safe?

@Anipik
Copy link
Contributor Author

Anipik commented Apr 7, 2020

@sunandabalu i ran the build and it passed https://dev.azure.com/dnceng/internal/_build/results?buildId=592010

@Anipik Anipik merged commit 553a6fd into dotnet:master Apr 7, 2020
@Anipik Anipik deleted the guardian branch April 7, 2020 21:35
mmitche pushed a commit that referenced this pull request Jun 26, 2020
@garath @Anipik
using self contained guardian package (#5212) (#5712)
ed69753 
Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericstj ericstj ericstj approved these changes

@sunandabalu sunandabalu sunandabalu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sdl tasks failing with .NET 5
4 participants
@Anipik @markwilkie @sunandabalu @ericstj