Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the Signing Model + some refactor #6594

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Nov 19, 2020

Add new tests for creation of the signing model and convert the project to using Fluent Assertions. Additionally:

  • Make DualSigningAllowed a bool (stronger typing)
  • Remove the redundant azure devops project attributes (which are unused) on the SigningInformation node in the manifest.
  • Add SignTool's verification of the various properties into the model.
  • Add a couple missing attributes on FileSignInfo

Add new tests for creation of the signing model and convert the project to using Fluent Assertions. Additionally:
- Make DualSigningAllowed a bool (stronger typing)
- Remove the redundant azure devops project attributes (which are unused) on the SigningInformation node in the manifest.
@mmitche
Copy link
Member Author

mmitche commented Nov 19, 2020

This covers #6425

Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

@mmitche mmitche merged commit 0775b66 into dotnet:master Nov 30, 2020
@mmitche mmitche deleted the signing-model-tests branch February 9, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants