Add sample of integrating client apps (WinForms & WPF) into an Aspire app #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianEdwards
requested review from
davidfowl,
mitchdenny,
eerhardt and
timheuer
timheuer
approved these changes
Jan 4, 2024
timheuer
reviewed
Jan 4, 2024
samples/ClientAppsIntegration/ClientAppsIntegration.WinForms/MainForm.Designer.cs
Show resolved
Hide resolved
|
@timheuer it's concerning that you're getting an error on the dashboard. Do the other samples work OK for you? |
Yep just this one, starter and others work fine |
|
@timheuer Can you get the exception/stack? |
|
@timheuer it just started showing up for me too! Not sure what changed... |
|
Umm not sure what's going on here... |
|
|
going to test a really dumb theory here...rebooting... |
|
theory failed -- I had two pending security updates and was randomly thinking they could be messing with crypto store |
|
@timheuer I just did a |
FWIW no change for me. I am maybe on diff SDK build and have been having some issues, so likely environment for me. |
DamianEdwards
changed the title
IEvangelist
reviewed
Jan 5, 2024
| internal static class Program | ||
| { | ||
| [STAThread] | ||
| public static void Main() |
There was a problem hiding this comment.
Suggested change
| public static void Main() | |
| public static async Task Main() |
| appHost.Start(); | ||
| app.Run(mainWindow); | ||
|
|
||
| appHost.StopAsync().GetAwaiter().GetResult(); |
There was a problem hiding this comment.
Suggested change
| appHost.StopAsync().GetAwaiter().GetResult(); | |
| await appHost.StopAsync(); |
There was a problem hiding this comment.
Not sure that's supported in WPF as I get the error below. async main in client UI apps isn't super useful anyway.
| /// The main entry point for the application. | ||
| /// </summary> | ||
| [STAThread] | ||
| static void Main() |
There was a problem hiding this comment.
Suggested change
| static void Main() | |
| static async Task Main() |
| ApplicationConfiguration.Initialize(); | ||
| Application.Run(ActivatorUtilities.CreateInstance<MainForm>(app.Services)); | ||
|
|
||
| app.StopAsync().GetAwaiter().GetResult(); |
There was a problem hiding this comment.
Suggested change
| app.StopAsync().GetAwaiter().GetResult(); | |
| await app.StopAsync(); |
eerhardt
reviewed
Jan 5, 2024
...s/ClientAppsIntegration/ClientAppsIntegration.WinForms/ClientAppsIntegration.WinForms.csproj
Show resolved
Hide resolved
eerhardt
reviewed
Jan 5, 2024
samples/ClientAppsIntegration/ClientAppsIntegration.AppDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jan 5, 2024
samples/ClientAppsIntegration/ClientAppsIntegration.Web/ClientAppsIntegration.Web.csproj
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sample of integrating client apps (WinForms & WPF for now but can be extended with MAUI, etc. at any point) into an Aspire app.
It adds an "AppDefaults" library project that is a more general version of the usual "ServiceDefaults" project, e.g. ASP.NET Core specific defaults aren't included, like endpoints, kestrel metrics, etc. The "ServiceDefaults" project is refactored to depend on the "AppDefaults" project and extend it. The client apps reference the "AppDefaults" project and the web apps reference the "ServiceDefaults" project as usual. This is something we could consider formalizing in our default experience.
The client app projects are added as a
ProjectReferenceto the AppHost project but as they target an incompatible TFM (net8.0-windows) they're configured to not reference the output assembly and to skip TFM checking. That then requires the projects are added to theDistributedApplicationBuildervia the project path, as the project metadata type is not generated.