Name must contain only ASCII letters, digits, and hyphens. (Parameter 'name')

[Depechie]

Preview 4 of Aspire gives following exception when trying to start the AppHost:

Unhandled exception. System.ArgumentException: Resource name 'basket.api' is invalid. Name must contain only ASCII letters, digits, and hyphens. (Parameter 'name')
   at Aspire.Hosting.ApplicationModel.ModelName.ValidateName(String target, String name) in /_/src/Aspire.Hosting/ApplicationModel/ModelName.cs:line 39
   at Aspire.Hosting.ApplicationModel.Resource..ctor(String name) in /_/src/Aspire.Hosting/ApplicationModel/Resource.cs:line 30
   at Aspire.Hosting.ApplicationModel.ProjectResource..ctor(String name) in /_/src/Aspire.Hosting/ApplicationModel/ProjectResource.cs:line 10
   at Aspire.Hosting.ProjectResourceBuilderExtensions.AddProject[TProject](IDistributedApplicationBuilder builder, String name) in /_/src/Aspire.Hosting/Extensions/ProjectResourceBuilderExtensions.cs:line 27

The culprit is in defining a project like:

var basketAPI = builder.AddProject<Projects.otel_Basket_API>("basket.api")

This works fine with preview 3.

[davidfowl]

Yep, we changed the naming constraints. Change the . to a dash or underscore

[davidfowl]

I think this means we should allow resources to override the name for service discovery.

[paulomorgado]

And for WithReference.

Let Aspire empower the developer without requiring changes in the resources.

And that would also reflect in the manifest.

[davidfowl]

We can restrict the names of the resources to whatever. Those are logical names. I think having an override for the service discovery name is a good feature to add

[paulomorgado]

I agree. I just think that, adding to that, there could be an override when adding the reference.

I could do it myself by adding an environment variable. But that becomes very verbose and not the same experience.

[davidfowl]

I think that’s what we’d do similar to what happens with WithReference for adding connection strings. You can override the name.

[razvangoga]

@davidfowl encountered the same exception when trying to move and exiting project from a docker compose setup to Aspire vis-a-vis the SqlServer db name.

XX_SOMENAME_SOMEOTHERNAME is a valid DB name in SqlServer

Unhandled exception. System.ArgumentException: Resource name 'XX_SOMENAME_SOMEOTHERNAME' is invalid. Name must contain only ASCII letters, digits, and hyphens. (Parameter 'name')
   at Aspire.Hosting.ApplicationModel.ModelName.ValidateName(String target, String name) in /_/src/Aspire.Hosting/ApplicationModel/ModelName.cs:line 39
   at Aspire.Hosting.ApplicationModel.Resource..ctor(String name) in /_/src/Aspire.Hosting/ApplicationModel/Resource.cs:line 30
   at Aspire.Hosting.ApplicationModel.SqlServerDatabaseResource..ctor(String name, String databaseName, SqlServerServerResource parent) in /_/src/Aspire.Hosting/SqlServer/SqlServerDatabaseResource.cs:line 14
   at Aspire.Hosting.SqlServerBuilderExtensions.AddDatabase(IResourceBuilder`1 builder, String name, String databaseName) in /_/src/Aspire.Hosting/SqlServer/SqlServerBuilderExtensions.cs:line 71

[davidfowl]

There's an overload of AddDatabase that takes the database name and it shouldn't be getting this validation error:

var db = builder.AddSqlServer("sql").AddDatabase("db", "XX_SOMENAME_SOMEOTHERNAME");

[razvangoga]

works thanks - didn't notice the overload - i guess that here then the validation would be done on the 1st prm?

if yes - then maybe point the users to this overload in the exception message.

eg : Resource name 'XX_SOMENAME_SOMEOTHERNAME' is invalid. Name must contain only ASCII letters, digits, and hyphens. (Parameter 'name'). If you really really wanna use this name, use the .AddDatabase("db", "XX_SOMENAME_SOMEOTHERNAME") overload