Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filtering traces by request path #1416

Open
DamianEdwards opened this issue Dec 15, 2023 Discussed in #1390 · 7 comments
Open

Support filtering traces by request path #1416

DamianEdwards opened this issue Dec 15, 2023 Discussed in #1390 · 7 comments
Labels
area-dashboard area-telemetry feature A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@DamianEdwards
Copy link
Member

Discussed in #1390

Originally posted by Kralizek December 14, 2023
My ASP.NET Core app with Razor Pages emits traces for static content. Is it possible to specify paths that should be ignored?

I also get traces for requests originated by the AWS SSM configuration provider.

Ideally, I'd love the traces to be less noisy:

  • only user initiated
  • avoid static content

Some screenshots:

image image image
@DamianEdwards DamianEdwards added area-dashboard feature A single user-facing feature. Can be grouped under an epic. labels Dec 15, 2023
@davidfowl
Copy link
Member

Shouldn't this be a generic filter based on span properties?

@DamianEdwards
Copy link
Member Author

Shouldn't this be a generic filter based on span properties?

Maybe, but exposing a first-class UI ability to filter by incoming request path built on top of a generic filter would likely be useful.

@davidfowl
Copy link
Member

davidfowl commented Dec 15, 2023

I don't think we should do that. These are spans (activities), not requests.

@DamianEdwards
Copy link
Member Author

Yes understood. What is the span-centric way of describing what's being shown? Is it just the display name or is the dashboard special-casing different span types and extracting specific info. for display here?

@davidfowl
Copy link
Member

I think the span name for requests happens to be the same as the path but we want filtering based on span attributes:

image

@samsp-msft
Copy link
Member

Are you asking to filter the requests in the UI, or suppress them being sent based on the type of the request. The latter is possible though the OTEL APIs to create a sampler that can work at the head or tail level.

https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/trace/tail-based-sampling-span-level

@davidfowl
Copy link
Member

Filter in the UI

@davidfowl davidfowl added this to the Backlog milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dashboard area-telemetry feature A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Development

No branches or pull requests

4 participants