Don't use batching on GenerateServiceMetadataSources Output #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Batching on the Outputs of GenerateServiceMetadataSources results in many, many calls to this target. The target itself is working in bulk and isn't doing anything that needs this output batching, so all that's happening is that more time is spent in the build performing needless target calls. Changing this to return the Item list directly results in one call, with one pass through the `ReferencePathWithRefAssemblies` items.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batching on the Outputs of GenerateServiceMetadataSources results in many, many calls to this target. The target itself is working in bulk and isn't doing anything that needs this output batching, so all that's happening is that more time is spent in the build performing needless target calls.
Changing this to return the Item list directly results in one call, with one pass through the
ReferencePathWithRefAssembliesitems.Before:
After:
I verified that the generated
ServiceMetadataSourceitems were equivalent before and after as well.