Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for providing a path to persist data from the Azurite container #1631

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

aaronpowell
Copy link
Contributor

@aaronpowell aaronpowell commented Jan 11, 2024

Fixes #1533

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jan 11, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 11, 2024
@DamianEdwards DamianEdwards changed the title Option for providing a path to persist data from the container Option for providing a path to persist data from the Azurite container Jan 11, 2024
@davidfowl
Copy link
Member

Why not a callback with the container resource? That way we don’t need to come back again when the next feature request comes in.

@mitchdenny mitchdenny assigned mitchdenny and davidfowl and unassigned mitchdenny Jan 11, 2024
@mitchdenny
Copy link
Member

There is no container resource, this simply adds an annotation. Any resource can be a container if it has the right annotation. I think having this as a parameter on UseEmulator(...) feels right - when you are using this method you are already in the context of configuring the emulator which supports this resource.

I think we should talk about options/settings patterns for builder extension methods in the offsite though - so perhaps we should hold this until next week (even though I think this is probably the right solution).

@mitchdenny mitchdenny added this to the preview 3 (Feb) milestone Jan 11, 2024
@aaronpowell
Copy link
Contributor Author

Yep, as @mitchdenny notes, we don't have a ContainerResource type available here, so we can't use the existing extension method, which is why I went with the parameters.

@davidfowl
Copy link
Member

Ah I see.

@davidfowl davidfowl merged commit e3fc7cc into dotnet:main Jan 13, 2024
8 checks passed
@aaronpowell aaronpowell deleted the aaronpowell/issue-1533 branch January 23, 2024 02:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The WithVolumeMount extension method doesn't work with Azurite
3 participants