Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up some left over issues from https://github.com/dotnet/aspire/pull/65 #165

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Oct 9, 2023

Minor fix ups.

  • Ensure the connectionName is mentioned in Validate
  • Fix READMEs that say "2nd parameter", which is now the 3rd
  • Remove unused variables in tests

- Ensure the connectionName is mentioned in Validate
- Fix READMEs that say "2nd parameter", which is now the 3rd
- Remove unused variables in tests
@eerhardt eerhardt merged commit 7cff350 into main Oct 10, 2023
4 checks passed
@eerhardt eerhardt deleted the Followup branch October 10, 2023 13:24
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants