Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest emitting external flag and http2 transport information. #198

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Manifest emitting external flag and http2 transport information. #198

merged 2 commits into from
Oct 11, 2023

Conversation

mitchdenny
Copy link
Member

This PR adds the ability for developers to mutate service bindings for specific publishers. Here is an example of the usage:

var app = builder.AddProject<Projects.Frontend>("frontend")
                            .WithServiceBindingForPublisher("manifest", "https", context => context.Binding.AsExternal());

When hitting F5 to debug locally, this would do nothing because the service bindings are derived from the launch profile. However when publishing a manifest the callback would be invoked and we can mark the binding as external. There is also AsHttp2() mutator as well. At this point in time the publisher argument is "stringy" but it could be made to be a generic as well.

Copy link

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think the design makes sense and I see how we can use it to unblock the end to end we want to deliver, so thanks for the fix (and having the checked in manifest, so I can easily see it work).

Less confident in my ability to review the actual implementation and know if there are any gaps, because I just have no real mental model of how this stuff works internally yet, but from the diff everything seems reasonable.

As a consumer of the manifest, this LGTM.

@mitchdenny mitchdenny merged commit edab416 into dotnet:main Oct 11, 2023
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants