Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide global environment variables by default #226

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Hide global environment variables by default #226

merged 1 commit into from
Oct 11, 2023

Conversation

tlmii
Copy link
Member

@tlmii tlmii commented Oct 11, 2023

  1. Adds a flag to the environment variables viewmodel specifying whether it is a spec variable or a global one. Values are always taken from the effective list regardless.
  2. By default, environment variables dialog shows only the ones from spec.
  3. Adds a toggle at the top of the dialog to switch between spec-only and all.
  4. Hides the toggle on containers, where there's (currently) no difference

Resolves #167

@tlmii
Copy link
Member Author

tlmii commented Oct 11, 2023

Screengrab:
SpecOnlyEnvVars

A couple things we need to settle on here:

  1. What icons should we use? I picked two to get us started, but they're not ideal.
  2. What should the tooltips on the button say for the two different states? Currently it is "Show All" and "Show Spec Only".

cc @leslierichardson95 on these questions in particular

@davidfowl
Copy link
Member

Does it load faster 😄

@tlmii tlmii merged commit ca252e5 into dotnet:main Oct 11, 2023
4 checks passed
@tlmii tlmii deleted the dev/project-env-vars branch October 11, 2023 19:29
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All environment variables user-wide showing now in dashboard
5 participants