Added basic RabbitMQContainerResource #299
Conversation
- This is pretty close to what eshop implements for its usage.
|
|
||
| public static class RabbitMQBuilderExtensions | ||
| { | ||
| public static IDistributedApplicationResourceBuilder<RabbitMQContainerResource> AddRabbitMQContainer(this IDistributedApplicationBuilder builder, string name, int? port = null) |
There was a problem hiding this comment.
I've been thinking ... should we ditch the port specification options here? Same for Postgres and Redis. And just let DCP allocate them?
There was a problem hiding this comment.
You mean ditch making them optional?
There was a problem hiding this comment.
No I mean ditching them altogether.
|
LOL, I was just about to do this! This looks like a reasonable start to me. Just one meta-comment around ports on the AddXYZ methods for resources. |
|
Might be worth considering password, oh and a connection string option as well. |
|
@mitchdenny Should I make this part of the manifest as a rabbitmq.v1 resource type? |
Yep. I don't think it'll need anything other than the type at this stage. |
- Support a password - Added manifest writing
|
Done, and tested with eshop |
Contributes to #231