Allow connection names in database components #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make database components consistent with Redis connection string structure.
- Add a string connectionName parameter to AddRedis
- Rename the keyed DI methods to .AddKeyedRedis.
- keep just the string name for now.
- Hosting changes to pass the component's name as the ConnectionStrings__{name} env var
eerhardt
requested review from
davidfowl,
DamianEdwards,
mitchdenny and
sebastienros
mitchdenny
reviewed
Oct 2, 2023
src/Aspire.Hosting/Postgres/PostgresContainerBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
mitchdenny
reviewed
Oct 2, 2023
mitchdenny
reviewed
Oct 2, 2023
mitchdenny
reviewed
Oct 2, 2023
mitchdenny
reviewed
Oct 2, 2023
src/Aspire.Hosting/Postgres/PostgresContainerBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
mitchdenny
reviewed
Oct 2, 2023
src/Aspire.Hosting/SqlServer/SqlServerCloudApplicationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
mitchdenny
approved these changes
Oct 2, 2023
davidfowl
reviewed
Oct 3, 2023
|
Do we update the configuration schema for this too? |
There aren't any changes to the configuration schema in this change. |
|
I've added tests and updated the READMEs. This should be ready for review now. |
davidfowl
approved these changes
Oct 4, 2023
mitchdenny
approved these changes
Oct 4, 2023
danmoseley
added
the
area-components
davidfowl
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Icons for Aspire.Hosting.Azure packages Using Azure Icons from Brand Central #3077 * Added readme files for Azure hosting packages #3077 Related Work Items: #30 * Fixup of Azure components readme - fixed references to now use split up package names * Fixing missed typo correction for CosmosDbClient * PR feedback: reference client libraries
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(In draft until I update READMEs and add tests for the new parameter).
Make database components consistent with Redis connection string structure.
Note: I also removed the SqlServer database from the sample app, since it doesn't do anything and only slows down and complicates the app.