Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow switching from system theme #307

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Allow switching from system theme #307

merged 3 commits into from
Oct 16, 2023

Conversation

tlmii
Copy link
Member

@tlmii tlmii commented Oct 16, 2023

Currently the dashboard always follows the system theme, but that's not necessarily what everyone wants. This PR does a couple of things:

  1. Adds a small settings dialog with these options for theme: System, Light, Dark
  2. Modifies the current theme immediately based on the selection in that dialog
  3. Sets a cookie based on the selection so that the setting is respected the next time it is launched rather than just defaulting to system theme.
  4. Fixes a few small issues with the dark theme in dialogs after Make dark theme darker #297

@tlmii
Copy link
Member Author

tlmii commented Oct 16, 2023

Screen recording:
SwitchFromSystemTheme

@dbreshears
Copy link
Contributor

Does it make sense to push to the bottom left?

@davidfowl
Copy link
Member

Or top right?

@tlmii
Copy link
Member Author

tlmii commented Oct 16, 2023

Went with top right because the alignment there was more straightforward than getting a nav menu link at the bottom:

SwitchFromSystemTheme2

@tlmii tlmii enabled auto-merge (squash) October 16, 2023 20:04
@tlmii tlmii merged commit 244477b into dotnet:main Oct 16, 2023
4 checks passed
@smitpatel smitpatel deleted the dev/theme-switcher branch October 16, 2023 20:54
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants