Support multiple deployments per cognitive service

[sebastienros]

Fixes #3409

Microsoft Reviewers: Open in CodeFlow

[sebastienros]

@JoshLove-msft is that something that could be made public, or in the opposite not used?

By that I mean this PR uses private reflection to access Resource.AddDependency().

[JoshLove-msft]

@JoshLove-msft is that something that could be made public, or in the opposite not used?

By that I mean this PR uses private reflection to access Resource.AddDependency().

Yeah this can be made public.

[JoshLove-msft]

@JoshLove-msft is that something that could be made public, or in the opposite not used?
By that I mean this PR uses private reflection to access Resource.AddDependency().

Yeah this can be made public.

Azure/azure-sdk-for-net#43257

[aaronpowell]

Should the AOAI demo in the playground folder be expanded to have multiple model deployments so there's an implementation

[mitchdenny]

This is good. Just need the updated version of CDK so we don't need to use reflection.

[danmoseley]

@joperezr I wonder whether it would help to retrain the labeler bot

[danmoseley]

although these things on the hosting side that are specific to a component, I'm not sure what to label

[eerhardt]

This is equivalent to @batchsize(1)
// which can't be defined with the CDK

When will this be available? That seems like the better long-term fix.

[mitchdenny]

We are waiting for this to merge and a build to be produced:

https://github.com/Azure/azure-sdk-for-net/pull/43285/files

@JoshLove-msft and @tg-msft can talk to timelines.

[JoshLove-msft]

Will be shipping today

[JoshLove-msft]

https://www.nuget.org/packages/Azure.Provisioning/0.2.0-beta.2

[sebastienros]

Thanks, reacting ASAP

[sebastienros]

When will this be available? That seems like the better long-term fix.

I think the question was not about the AddDependency being made public, but the support for @batchSize(1).

[sebastienros]

Updated with public method and tried it with one and two deployments successfully.

[eerhardt]

LGTM

[eerhardt]

/backport to release/8.0

[github-actions]

Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8885059518

[github-actions]

@eerhardt backporting to release/8.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Support multiple deployments per cognitive service
Applying: Use local method
Applying: Use public method
Using index info to reconstruct a base tree...
M	Directory.Packages.props
Falling back to patching base and 3-way merge...
Auto-merging Directory.Packages.props
CONFLICT (content): Merge conflict in Directory.Packages.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Use public method
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[github-actions]

@eerhardt an error occurred while backporting to release/8.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.