Calculate display summary for span #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JamesNK Can you also add the semantic conventions for messaging https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/
|
|
Done. Prefixed with
|
JamesNK
force-pushed
the
jamesnk/span-display-summary
branch
from
ad7b731
to
3ae0c0c
Compare
davidfowl
approved these changes
Oct 19, 2023
davidfowl
reviewed
Oct 19, 2023
| @@ -45,7 +45,7 @@ | |||
|
|
|||
| <FluentDataGrid Class="trace-view-grid" ResizableColumns="true" ItemsProvider="@GetData" TGridItem="SpanWaterfallViewModel" RowClass="@GetRowClass" GridTemplateColumns="2fr 6fr"> | |||
| <TemplateColumn Title="Name"> | |||
| <div class="col-long-content" title="@($"{context.Span.Source.ApplicationName}: {context.Span.Name}")"> | |||
| <div class="col-long-content" title="@($"{context.Span.Source.ApplicationName}: {context.GetDisplaySummary()}")"> | |||
There was a problem hiding this comment.
Is there a tooltip for this thing?
|
Ship it! |
|
Not seeing the MSG for rabbit MQ in eshop: 
I think it's because I'm using the Producer span type vs the Client span type. I don't know which one is right but since service bus is working, I'll tweak it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
Note: There isn't a friendly "statement" for database calls. For example, postgres adds the entire SQL string to the span statement. I used the span name instead.