Adds Azurite support

[bjorkstromm]

I toyed a little with creating resources and thought Azurite would be good for local dev.

[davidfowl]

This should be part of the azure package. Thanks for the contribution!

[davidfowl]

This is very cool but we should model this into the AddAzureStorage somehow. Maybe as an overload or as another method.

[bjorkstromm]

This is very cool but we should model this into the AddAzureStorage somehow. Maybe as an overload or as another method.

Thanks for the comments. I've integrated it i Aspire.Hosting.Azure now. I added a extension method UseEmulator which registers annotations on the Azure storage resource. I also took measures to ensure emulators are not provisioned using AzureProvisioner.

Example AppHost

var builder = DistributedApplication.CreateBuilder(args);

var azurite = builder.AddAzureStorage("azurite")
                     .UseEmulator();

var blob = azurite.AddBlobs("blobs");
var queue = azurite.AddQueues("queues");
var table = azurite.AddTables("tables");

builder.AddProject<Projects.Web>("web")
       .WithReference(blob)
       .WithReference(queue)
       .WithReference(table);

builder.Build().Run();

Example web api

using Azure.Data.Tables;
using Azure.Storage.Blobs;
using Azure.Storage.Queues;

var builder = WebApplication.CreateBuilder(args);
builder.AddAzureTableService("tables");
builder.AddAzureBlobService("blobs");
builder.AddAzureQueueService("queues");

var app = builder.Build();

app.MapGet("/tables", (TableServiceClient client) => client.Query());
app.MapGet("/blobs", (BlobServiceClient client) => client.GetBlobContainers());
app.MapGet("/queues", (QueueServiceClient client) => client.GetQueues());

app.Run();

[davidfowl]

This is beautiful, but you have to resolve some merge conflicts 😄

[mitchdenny]

Agreed. This looks pretty good. I'm somewhat uncomfortable with the IsEmulator property but that is mostly because I don't know how the storage resource type will evolve. For now I think it can stay until we get a good sense on whether it is in the right place or note.

In terms of verbs applied to extension methods we now have WithX, UseX, and AddX. I think it would be good to establish some guidelines around which is appropriate when.

Usage / Verb	AddX	WithX	UseX
App builder	Use to add resources and lifecycle hooks to the application model.	Not used.	Not used.
Resource builder	Add sub-resources to an existing resource	Use to add annotations (e.g. bindings, references) to a resource.	Change underlying hosting model for resource (e.g. container vs. real resource via provisioner).

[davidfowl]

Good point @mitchdenny. I think Use or As would apply here. UseEmulator/AsEmulator, I think I prefer Use

[davidfowl]

There are some more merge conflicts to fix because of the rename but they shouldn't affect you much. 2 changes you should make:

1. Add a ShouldProvision to IAzureResourceProvisioner and use it in the main loop, use it from here

   aspire/src/Aspire.Hosting.Azure.Provisioning/Provisioners/AzureProvisioner.cs

   Line 197 in 65ba642

   if (provisoner.ConfigureResource(configuration, resource))

   .
2. Then implement it in the AzureStorageProvisioner

That will allow you to skip provisioning storage when the emulator is changed.

Lets get this merged soon! Sorry for the churn.

[bjorkstromm]

@davidfowl Thanks for the review comments. I've rebased, fixed merge conflicts and addressed your feedback comments.

Starting AppHost with AzureProvisioning on will now yield the following logs if emulator is used.

info: Aspire.Hosting.Azure.AzureProvisioner[0]
      Skipping azurite because it is not configured to be provisioned.
warn: Aspire.Hosting.Azure.AzureProvisioner[0]
      No provisioner found for AzureBlobStorageResource skipping.
warn: Aspire.Hosting.Azure.AzureProvisioner[0]
      No provisioner found for AzureQueueStorageResource skipping.
warn: Aspire.Hosting.Azure.AzureProvisioner[0]
      No provisioner found for AzureTableStorageResource skipping.

[davidfowl]

Very clean, this is a high quality PR 😄. Thanks!