Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some initial doc comments to the application model #420

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

davidfowl
Copy link
Member

@davidfowl davidfowl commented Oct 20, 2023

PS: Comments can get very nit picky, so feel free to edit them as you see fit and I can commit those changes. My goal is to have this in by tomorrow and we can make as many follow up changes as people like.

Fixes #42
Fixes #417

src/Aspire.Hosting.Azure/AzureResourceExtensions.cs Outdated Show resolved Hide resolved
src/Aspire.Hosting/ContainerResourceBuilderExtensions.cs Outdated Show resolved Hide resolved
src/Aspire.Hosting/ResourceBuilderExtensions.cs Outdated Show resolved Hide resolved
src/Aspire.Hosting/ResourceBuilderExtensions.cs Outdated Show resolved Hide resolved
src/Aspire.Hosting/ResourceBuilderExtensions.cs Outdated Show resolved Hide resolved
src/Aspire.Hosting/ResourceBuilderExtensions.cs Outdated Show resolved Hide resolved
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start to standardise our arg names here. We've got a few inconsistencies around.

@davidfowl davidfowl merged commit 0deeb57 into main Oct 20, 2023
4 checks passed
@davidfowl davidfowl deleted the davidfowl/doc-comments branch October 20, 2023 18:31
@danmoseley danmoseley added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WithServiceBinding passes the name of the endpoint as the transport Aspire.Hosting APIs need doc comments
6 participants