Update view model snapshot correctly in cache #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
approved these changes
Oct 25, 2023
| switch (objectChangeType) | ||
| { | ||
| case ObjectChangeType.Added: | ||
| _resourcesMap.Add(resource.Name, resource); |
There was a problem hiding this comment.
I think it was commented in a previous PR for a different section that the Added/Modified cases are effectively the same (unless we get an add for something already present, which would throw an exception. I'm ok with the distinction, just noting it since it caused me some confusion last night when "modified" changes for something not already in the map acted like adds.
There was a problem hiding this comment.
The separation helps with re-add errors. The case you show won't cover. If we collapse then it would make behavior you see occur for more scenarios, hiding potentially more errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed we were not removing deleted resource from snapshot.