Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Npgsql Metrics (#658) #660

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Fix Npgsql Metrics (#658) #660

merged 1 commit into from
Nov 2, 2023

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Nov 2, 2023

  • Restore disabled counter

This was missed in #648

Addresses #645

  • Add view to Npgsql's histograms because they are in seconds and not ms.

Fix #641

@eerhardt
Fix Npgsql Metrics (#658)
3350d87 
* Restore disabled counter

This was missed in #648

Addresses #645

* Add view to Npgsql's histograms because they are in seconds and not ms.

Fix #641
@joperezr joperezr merged commit ff558bb into release/8.0-preview1 Nov 2, 2023
6 checks passed
@joperezr joperezr deleted the PortNpgsqlMetrics branch November 2, 2023 18:09
@eerhardt eerhardt mentioned this pull request Nov 2, 2023
Closed
@danmoseley danmoseley added the area-components Issues pertaining to Aspire Component packages label Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@joperezr joperezr joperezr approved these changes

@DamianEdwards DamianEdwards Awaiting requested review from DamianEdwards

@JamesNK JamesNK Awaiting requested review from JamesNK

@danmoseley danmoseley Awaiting requested review from danmoseley

Assignees
No one assigned
Labels
area-components Issues pertaining to Aspire Component packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eerhardt @davidfowl @joperezr @danmoseley