Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sample base image #919

Merged
merged 1 commit into from Nov 17, 2023
Merged

update sample base image #919

merged 1 commit into from Nov 17, 2023

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Nov 17, 2023 •
edited

update sample base image, remove -preview suffix since .NET 8 had released

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-components Issues pertaining to Aspire Component packages label Nov 17, 2023
danmoseley
danmoseley approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @WeihanLi

@danmoseley danmoseley merged commit 74c4070 into dotnet:main Nov 17, 2023
3 checks passed
@WeihanLi WeihanLi deleted the patch-1 branch November 17, 2023 06:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

Assignees
No one assigned
Labels
area-components Issues pertaining to Aspire Component packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WeihanLi @danmoseley