Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ArgumentOutOfRangeException.ThrowIfNullOrWhiteSpace usage in FileUtil #933

Merged
merged 2 commits into from Nov 17, 2023
Merged

Update ArgumentOutOfRangeException.ThrowIfNullOrWhiteSpace usage in FileUtil #933

merged 2 commits into from Nov 17, 2023

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Nov 17, 2023 •
edited

use Debug.Assert instead

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Nov 17, 2023
@danmoseley
Copy link
Member

This is strictly speaking a breaking change (not that it matters much in Preview), but it does seem like an improvement.

@WeihanLi
Copy link
Contributor Author

This is strictly speaking a breaking change

Which kind of breaking change it would belong to? Behavior breaking change?

Since the type is internal, think it would not break the usage, and the behavior should keep the same as before.

eerhardt
eerhardt approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@WeihanLi WeihanLi changed the title use ArgumentException.ThrowIfNullOrWhiteSpace Update ArgumentOutOfRangeException.ThrowIfNullOrWhiteSpace usage in FileUtil Nov 17, 2023
@danmoseley
Copy link
Member

Since the type is internal, think it would not break the usage,

It was too early in the morning, I missed that. Thanks

@eerhardt eerhardt merged commit a7901cd into dotnet:main Nov 17, 2023
3 checks passed
@WeihanLi
Copy link
Contributor Author

Never mind, thanks very much

@danmoseley danmoseley added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Nov 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WeihanLi @danmoseley @eerhardt