Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issues with dotnet-openapi tests in latest SDK #32686

Closed
captainsafia opened this issue May 14, 2021 · 5 comments
Closed

Resolve issues with dotnet-openapi tests in latest SDK #32686

captainsafia opened this issue May 14, 2021 · 5 comments
Assignees
@dougbu
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI task
Milestone
7.0-preview1

Comments

@captainsafia
Copy link
Member

captainsafia commented May 14, 2021 •
edited

Following the latest SDK bump in #32581, the dotnet-openapi tests are failing due to some issues with the new workload resolution flag.

  Error Message:
   Threw error: The SDK 'Microsoft.NET.SDK.WorkloadAutoImportPropsLocator' specified could not be found.  /Users/captainsafia/github.com/dotnet/aspnetcore/.dotnet/sdk/6.0.100-preview.5.21264.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.props

Expected: True
Actual:   False
  Stack Trace:
     at Microsoft.DotNet.OpenApi.Tests.OpenApiTestBase.AssertNoErrors(Int32 appExitCode) in /Users/captainsafia/github.com/dotnet/aspnetcore/src/Tools/Microsoft.dotnet-openapi/test/OpenApiTestBase.cs:line 116
   at Microsoft.DotNet.OpenApi.Add.Tests.OpenApiAddURLTests.OpenApi_Add_Url() in /Users/captainsafia/github.com/dotnet/aspnetcore/src/Tools/Microsoft.dotnet-openapi/test/OpenApiAddURLTests.cs:line 158
--- End of stack trace from previous location ---

And when run locally:

❯ ~/github.com/dotnet/aspnetcore/.dotnet/dotnet ~/github.com/dotnet/aspnetcore/artifacts/bin/Microsoft.dotnet-openapi/Debug/net6.0/dotnet-openapi.dll add url "https://google.com"
Downloading to '/Users/captainsafia/github.com/dotnet/aspnetcore/src/Tools/Microsoft.dotnet-openapi/test/google.json'.

The SDK 'Microsoft.DotNet.Arcade.Sdk' specified could not be found.  /Users/captainsafia/github.com/dotnet/aspnetcore/Directory.Build.props

Skipping the tests for now to unblock our build issues but we'll need to follow-up on this once we have a resolution in the SDK.

Ref: dotnet/sdk#17461
@captainsafia captainsafia added task area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI labels May 14, 2021
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone May 17, 2021
@ghost
Copy link

ghost commented May 17, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

dougbu added a commit that referenced this issue Sep 4, 2021
@dougbu
Stop skipping dotnet openapi
3efb927 
- .NET SDKs and Visual Studio's `msbuild` avoid #32686
@dougbu dougbu self-assigned this Sep 4, 2021
@dougbu
Copy link
Member

dougbu commented Sep 4, 2021

I'm pretty sure there's nothing to "resolve" here. Testing in #36171

@captainsafia
Copy link
Member Author

@dougbu A subsequent SDK update probably resolved the issue. As I recall, this particular stacktrace was tracked down to an external issue.

@dougbu
Copy link
Member

dougbu commented Sep 7, 2021

@captainsafia please review #36171. Then we can close this 😀

@dougbu dougbu mentioned this issue Sep 9, 2021
Merged
dougbu added a commit that referenced this issue Sep 10, 2021
@dougbu
Handle shortened JSON file in dotnet openapi (#36171)
e23fd04 
* Handle shortened JSON file in `dotnet openapi`
  - #35767
  - an existing JSON file must be truncated
* !fixup! Address nits in changed file
  - take VS suggestions
* Stop skipping `dotnet openapi` tests
  - .NET SDKs and Visual Studio's `msbuild` avoid #32686 already
* !fixup! Address nits in `dotnet openapi` test files
  - take VS suggestions
* Extend `dotnet openapi refresh` tests
  - include regression test for #35767
github-actions bot pushed a commit that referenced this issue Sep 10, 2021
@dougbu
Stop skipping dotnet openapi - .NET SDKs and Visual Studio's `msbui…
2b36bd6 
…ld` avoid #32686
dougbu pushed a commit that referenced this issue Sep 10, 2021
@github-actions
[release/6.0] Handle shortened JSON file in dotnet openapi (#36355)
e259201 
* Clean backport of e23fd04

* Handle shortened JSON file in `dotnet openapi`
  - #35767
  - an existing JSON file must be truncated
* !fixup! Address nits in changed file
  - take VS suggestions
* Stop skipping `dotnet openapi` tests
  - .NET SDKs and Visual Studio's `msbuild` avoid #32686 already
* !fixup! Address nits in `dotnet openapi` test files
  - take VS suggestions
* Extend `dotnet openapi refresh` tests
  - include regression test for #35767
This was referenced Sep 10, 2021
Merged
Merged
@dougbu
Copy link
Member

dougbu commented Sep 10, 2021

Issue is not mentioned in release/3.1 or release/5.0.

@dougbu dougbu closed this as completed Sep 10, 2021
@dotnet dotnet locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI task
Projects
None yet
Milestone
7.0-preview1
Development

No branches or pull requests
3 participants
@captainsafia @dougbu @mkArtakMSFT