Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build template packages in servicing #40637

Closed
MichaelSimons opened this issue Mar 10, 2022 · 6 comments · Fixed by #40643
Closed

Build template packages in servicing #40637

MichaelSimons opened this issue Mar 10, 2022 · 6 comments · Fixed by #40643
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed

Comments

@MichaelSimons
Copy link
Member

Currently building release/6.0 doesn't produce the template packages.

Microsoft.DotNet.Web.ItemTemplates
Microsoft.DotNet.Web.ProjectTemplates
Microsoft.DotNet.Web.Spa.ProjectTemplates

This doesn't work well for .NET source-build which needs to product the entire product for every build (e.g. previews, rtm, servicing, etc).

Would it be amenable to always produce the template packages during servicing builds? An alternative less desirable option would be to build them only in source-build.

Currently source-build treats these packages as text-only packages that are checked in/reverse engineered. This solution is not ideal as it requires manual updates, is a maintenance burden, and in general is problematic.

This issue is similar in nature to #39471 and dotnet/templating#4337.

@javiercn javiercn added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 10, 2022
@javiercn
Copy link
Member

@MichaelSimons thanks for bringing this up to our attention.

@dotnet/aspnet-build do you know what might be going on here?

@wtgodbe
Copy link
Member

wtgodbe commented Mar 10, 2022

The template packages do get built in servicing builds, see the PackageArtifacts of a recent 6.0 build here: https://dev.azure.com/dnceng/internal/_build/results?buildId=1654283&view=artifacts&pathAsName=false&type=publishedArtifacts

@MichaelSimons
Copy link
Member Author

@wtgodbe, Thanks for pointing that out. They aren't getting built in source-build - https://dev.azure.com/dnceng/_apis/resources/Containers/9800566/PackageArtifacts?itemPath=PackageArtifacts%2FMicrosoft.SourceBuild.Intermediate.aspnetcore.6.0.4-servicing.22159.2.nupkg. Is this something you can help address?

@wtgodbe
Copy link
Member

wtgodbe commented Mar 10, 2022

Ah, sorry for the confusion - we exclude everything except the targeting pack & SharedFx (which bring in all other src projects) from source build. I can add the templates to that exclusion list as well. Do you need this further back than 6.0?

@MichaelSimons
Copy link
Member Author

Getting this fixed in main and release/6.0 is sufficient. Thanks.

@wtgodbe
Copy link
Member

wtgodbe commented Mar 10, 2022

#40643

@wtgodbe wtgodbe added the Done This issue has been fixed label Mar 10, 2022
@wtgodbe wtgodbe self-assigned this Mar 10, 2022
@wtgodbe wtgodbe reopened this Mar 21, 2022
@wtgodbe wtgodbe closed this as completed Apr 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants