-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom build options #450
Comments
I'm confirming that custom build options would be a requirement to properly integrate PostSharp with ASP.NET v5. What we need to match is the MSBuild ability to pass custom properties from the command line. We would need a similar mechanism to pass custom build options or custom properties to the project/application context. The workaround currently would be to pass the properties through environment variables, but this is not as convenient. Custom properties could be passed using a command-line argument like Custom properties could be exposed as a service to be consumed from
Would that be an acceptable pull request? |
So potential problems:
I'm not ready to accept pull requests that change that much of the pipeline yet. We're actually in the middle of a major rewrite/refactor of the runtime. |
Namespace: I would let that problem to conventions. For instance the property name could be dotted. Runtime compilation: That would work the same. We just want to pass temporary options through the command line. But it means there should be a way to pass permanent options to |
Another problem: the scope of Some use cases for custom options in PostSharp:
|
I would like to know if the feature would be accepted as a pull request and what would be the design approval process (because I would like to get approval before investing more time). Thanks. |
After analysis, here is my proposal: End user's perspective
ICompilerModule's perspective
Exposing properties on DNX perspective
Open questions
I'm looking forward to reading your feedback to know if I can move further with this design. |
@davidfowl Any comment on this proposal? Such as "awesome", "no way", "wait after //build/", "bother my colleague X" ... |
@gfraiteur This is promising /cc @victorhurdugaci |
Msbuild is back 😉 |
How can custom compiler extensions (ICompilerModule or IProjectCompiler) consume project options, so these extensions can consume custom options?
Thank you.
The text was updated successfully, but these errors were encountered: