Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset size limit warnings when building in CodeSpaces #47324

Closed
1 task done
amcasey opened this issue Mar 20, 2023 · 7 comments
Closed
1 task done

Asset size limit warnings when building in CodeSpaces #47324

amcasey opened this issue Mar 20, 2023 · 7 comments
Labels
area-blazor Includes: Blazor, Razor Components Pillar: Technical Debt task

Comments

@amcasey
Copy link
Member

amcasey commented Mar 20, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Create a new CodeSpace for this repo and run eng/build.sh - configuration release. You get errors like

/workspaces/aspnetcore/eng/targets/Npm.Common.targets(92,5): error : in asset size limit: The following asset(s) exceed the recommended size limit (120 KiB). [/workspaces/aspnetcore/src/Components/Web.JS/Microsoft.AspNetCore.Components.Web.JS.npmproj]
This can impact web performance.
Assets:
   blazor.server.js (133 KiB)

/workspaces/aspnetcore/src/Components/WebAssembly/WebAssembly.Authentication/src/Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj(78,5): error : in asset size limit: The following asset(s) exceed the recommended size limit (120 KiB).
This can impact web performance.
Assets:
   AuthenticationService.js (285 KiB)

Expected Behavior

No errors from yarn.

Steps To Reproduce

Create a new CodeSpace for this repo and run eng/build.sh - configuration release. Mitigation: /p:IgnoreYarnWarnings=true

Exceptions (if any)

No response

.NET Version

No response

Anything else?

You might also get errors about microsoft.internal.runtime.aspnetcore.transport not having xml files - they're unrelated.

@amcasey
Copy link
Member Author

amcasey commented Mar 20, 2023

FYI @javiercn

@javiercn
Copy link
Member

@amcasey we are aware of these. I think we are using the default values on our build and never bothered to change them ¯_(ツ)_/¯

That normally is a warning and should not impact the build. Is it giving you problems?

@amcasey
Copy link
Member Author

amcasey commented Mar 20, 2023

@javiercn I'm pretty sure it failed my build or I would have just ignored it.

@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 17, 2023
@wtgodbe wtgodbe added area-blazor Includes: Blazor, Razor Components Pillar: Technical Debt labels Nov 29, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Nov 29, 2023

Related: #37398, #11592

@wtgodbe wtgodbe added task and removed area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Nov 29, 2023
@wtgodbe wtgodbe added this to the Planning: WebUI milestone Nov 29, 2023
@ghost
Copy link

ghost commented Dec 18, 2023

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT
Copy link
Member

Parking it in 9 to spend a few hours to see if we can come up with a good solution. If not, we'll deprioritize then.

@mkArtakMSFT
Copy link
Member

Closing as we've switched bundlers and this was coming from the old bundler.

@mkArtakMSFT mkArtakMSFT closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components Pillar: Technical Debt task
Projects
None yet
Development

No branches or pull requests

5 participants
@javiercn @amcasey @wtgodbe @mkArtakMSFT and others