Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gRPC JSON transcoding property priority #47349

Closed
1 task done
JamesNK opened this issue Mar 21, 2023 · 1 comment · Fixed by #47385
Closed
1 task done

Update gRPC JSON transcoding property priority #47349

JamesNK opened this issue Mar 21, 2023 · 1 comment · Fixed by #47385
Assignees
Labels
area-grpc Includes: GRPC wire-up, templates

Comments

@JamesNK
Copy link
Member

JamesNK commented Mar 21, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Google.Protobuf has fixed their property priority so json_name always wins - protocolbuffers/protobuf#12262

Apply change to gRPC JSON transcoding to use the same behavior.

Expected Behavior

json_name always wins. Should be applied to JSON deserialization and query string and route parameter binding.

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

@JamesNK JamesNK added the area-grpc Includes: GRPC wire-up, templates label Mar 21, 2023
@JamesNK JamesNK added this to the .NET 8 Planning milestone Mar 21, 2023
@ghost
Copy link

ghost commented Mar 21, 2023

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@JamesNK JamesNK self-assigned this Mar 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant