Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IProblemDetailsService in ValidationProblem #47631

Open
1 task done
bjornen77 opened this issue Apr 10, 2023 · 3 comments · May be fixed by #51464
Open
1 task done

Use IProblemDetailsService in ValidationProblem #47631

bjornen77 opened this issue Apr 10, 2023 · 3 comments · May be fixed by #51464
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc

Comments

@bjornen77
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Validation problem should use IProblemDetailsService in the same way as #47045

Describe the solution you'd like

I think that ValidationProblem (Microsoft.AspNetCore.Http.HttpResults) should also use the IProblemDetailsService in the same way as #47045 to be able to customize the validation problem in one place.

Additional context

No response

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 10, 2023
@MackinnonBuck MackinnonBuck added area-web-frameworks and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Apr 11, 2023
@captainsafia captainsafia added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-web-frameworks labels Jun 20, 2023
dnperfors added a commit to dnperfors/aspnetcore that referenced this issue Oct 18, 2023
@dnperfors dnperfors linked a pull request Oct 18, 2023 that will close this issue
@dnperfors
Copy link
Contributor

I just created a PR for this. I guess this will be to late for .NET 8 or can it be sneaked in for consistency reasons?

@martincostello
Copy link
Member

At this point, I believe .NET 8 is "done" - there's no such thing as "sneaking it in" once they lock down the branches, which typically happens once they permanently branch off of main before the first release candidate.

@dnperfors
Copy link
Contributor

dnperfors commented Oct 18, 2023

Technically .NET 8 is still a release candidate and this is an oversight, but probably not severe enough to warrant including it in the upcoming release... But I do hope the team will consider backporting this one :)

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@dnperfors @martincostello @captainsafia @MackinnonBuck @wtgodbe @bjornen77 and others