Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArgumentException.ThrowIfNullOrEmpty #50665

Closed
divyeshio opened this issue Sep 12, 2023 · 0 comments · Fixed by #52897
Closed

Use ArgumentException.ThrowIfNullOrEmpty #50665

divyeshio opened this issue Sep 12, 2023 · 0 comments · Fixed by #52897
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team

Comments

@divyeshio
Copy link
Contributor

Background and Motivation

Creating this new issue for changes related to ArgumentException.ThrowIfNullOrEmpty helper specifically, in order to keep it separate from #48185 and make the changes more easily reviewable

Similar to dotnet/runtime#64357.
@divyeshio divyeshio added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Sep 12, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Sep 12, 2023
@divyeshio divyeshio mentioned this issue Sep 12, 2023
Closed
4 tasks
@gfoidl gfoidl added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed api-suggestion Early API idea and discussion, it is NOT ready for implementation needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Sep 13, 2023
@amcasey amcasey added the help wanted Up for grabs. We would accept a PR to help resolve this issue label Sep 14, 2023
@mkArtakMSFT mkArtakMSFT added help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team and removed help wanted Up for grabs. We would accept a PR to help resolve this issue labels Oct 28, 2023
aligoren pushed a commit to aligoren/aspnetcore that referenced this issue Oct 28, 2023
Use ArgumentNullException instead null coalescing
1d1fbdd 
According to the dotnet#50665 I have made a small change. With this change, this method will not use null coalescing operators to fire the ArgumentNullException exception.

It will use ArgumentNullException.ThrowIfNull instead of it.
@aligoren aligoren mentioned this issue Oct 28, 2023
Merged
4 tasks
@joegoldman2 joegoldman2 mentioned this issue Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team
Projects
None yet
Milestone
No milestone
4 participants
@gfoidl @amcasey @mkArtakMSFT @divyeshio