Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Blazor WebAssembly perf benchmarks to use a different docker image #55813

Open
MackinnonBuck opened this issue May 21, 2024 · 1 comment
Open

Update the Blazor WebAssembly perf benchmarks to use a different docker image #55813

MackinnonBuck opened this issue May 21, 2024 · 1 comment
Assignees
@MackinnonBuck
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly Perf task
Milestone
9.0-preview7

Comments

@MackinnonBuck
Copy link
Member

The Blazor WebAssembly performance benchmarks have been making our builds yellow for some time now, so we've disabled them as of #55812.

The fix is either to add the selenium/standalone-chrome Docker image to MCR or use a different image and set up Chrome and Selenium manually in the Dockerfile. The latter may end up being the better short-term solution.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label May 21, 2024
@MackinnonBuck MackinnonBuck added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework task labels May 21, 2024
@MackinnonBuck MackinnonBuck self-assigned this May 21, 2024
@MackinnonBuck MackinnonBuck added this to the 9.0-preview6 milestone May 21, 2024
@MackinnonBuck
Copy link
Member Author

Another option might be to use the MCR Playwright docker image and migrate the WebAssembly benchmarks over to Playwright.

@mkArtakMSFT mkArtakMSFT added feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly and removed area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MackinnonBuck MackinnonBuck

Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly Perf task
Projects
None yet
Milestone
9.0-preview7
Development

No branches or pull requests
2 participants
@MackinnonBuck @mkArtakMSFT