Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out selenium/standalone-chrome container images. #55812

Merged
merged 1 commit into from
May 21, 2024

Conversation

mitchdenny
Copy link
Member

This PR comments out the use of selenium/stable-chrome for the benchmark projects. See comment in the source file with a link to the MCR pull request to try to eventually enable us to continue using them. It is possible that continuing to use these images will be too much of a compliance hurdle (unless anyone wants to commit to doing a source build of the images).

@mitchdenny mitchdenny requested a review from a team as a code owner May 21, 2024 01:18
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label May 21, 2024
@mitchdenny mitchdenny self-assigned this May 21, 2024
@mitchdenny mitchdenny added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 21, 2024
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This will disable the Blazor WebAssembly perf benchmarks, but we can update this Dockerfile later to use a different image and set up chrome/selenium manually.

@mitchdenny mitchdenny merged commit e577ff3 into main May 21, 2024
26 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/comment-outcontainer-images branch May 21, 2024 03:49
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview5 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants