Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some samples do not work out of box #7288

Open
ryanbrandenburg opened this issue Feb 5, 2019 · 3 comments
Open

Some samples do not work out of box #7288

ryanbrandenburg opened this issue Feb 5, 2019 · 3 comments
Labels
affected-few This issue impacts only small number of customers area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer severity-minor This label is used by an internal tool task
Milestone

Comments

@ryanbrandenburg
Copy link
Contributor

At least the following samples do not work if you do .\build.cmd move into their directory and do dotnet run.

These samples should either be fixed so that an outside user can run them without modification (or if modification is required for config or some such, it should be explicitly called out in the error message), or removed entirely if they no longer serve a purpose.

More generally it would be a good idea for us build and test basic functionality of all our samples (IE, index page returns 200) so we can ensure that they are up to date and not misleading to customers.

@Eilon Eilon added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Feb 5, 2019
@Tratcher
Copy link
Member

Tratcher commented Feb 5, 2019

I just fixed one issue with the missing launchsettings in #7105.

The other blocker here is that these scenarios require client secrets, it's a very bad practice to check those into source control. That also prevents automated testing.

Some of these samples have explicit config instructions such as https://github.com/aspnet/AspNetCore/blob/b21c09665e868526057dd3785f1d4518359b9a25/src/Security/Authentication/samples/SocialSample/Startup.cs#L51-L56

@Tratcher
Copy link
Member

Tratcher commented Feb 6, 2019

Also, these samples should stay as they make for very good manual verification of the various providers.

@ryanbrandenburg
Copy link
Contributor Author

Yeah, if you have uses for these by all means keep them. The error message you linked is pretty good, but maybe it could call out specifically where to set that config, or link to docs on the subject?

@Eilon Eilon added this to the Backlog milestone Feb 7, 2019
@Tratcher Tratcher added affected-few This issue impacts only small number of customers severity-minor This label is used by an internal tool task labels Nov 10, 2020 — with ASP.NET Core Issue Ranking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-few This issue impacts only small number of customers area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer severity-minor This label is used by an internal tool task
Projects
None yet
Development

No branches or pull requests

3 participants