Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor #11307

Merged
merged 5 commits into from
Jun 21, 2019
Merged

[master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor #11307

merged 5 commits into from
Jun 21, 2019

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 18, 2019 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/aspnet/AspNetCore-Tooling

  • Build: 20190620.3
  • Date Produced: 6/20/2019 11:30 PM
  • Commit: a399bd072e04f394de843ac100bd16fdd926a993
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.NET.Sdk.Razor -> 3.0.0-preview7.19320.3
    • Microsoft.CodeAnalysis.Razor -> 3.0.0-preview7.19320.3
    • Microsoft.AspNetCore.Razor.Language -> 3.0.0-preview7.19320.3
    • Microsoft.AspNetCore.Mvc.Razor.Extensions -> 3.0.0-preview7.19320.3

From https://github.com/aspnet/Blazor

  • Build: 20190617.1
  • Date Produced: 6/17/2019 12:57 PM
  • Commit: 03f3e4a1a88037d9bbdd21334706ff147d616148
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.AspNetCore.Blazor.Mono -> 0.10.0-preview7.19317.1

@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner June 18, 2019 02:03
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 18, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: AspNetCore-ci, AspNetCore-ci (Build: Windows x64/x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/AspNetCore-Tooling [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor Jun 18, 2019
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling Jun 18, 2019
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor Jun 18, 2019
@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 18, 2019
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling Jun 19, 2019
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor Jun 19, 2019
dotnet-maestro added 2 commits June 18, 2019 21:53
@dougbu
Update dependencies from https://github.com/aspnet/AspNetCore-Tooling …
4aa2762 
…build 20190617.1

- Microsoft.NET.Sdk.Razor - 3.0.0-preview7.19317.1
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview7.19317.1
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview7.19317.1
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview7.19317.1
@dougbu
Update dependencies from https://github.com/aspnet/Blazor build 20190…
f3a3559 
…617.1

- Microsoft.AspNetCore.Blazor.Mono - 0.10.0-preview7.19317.1
@dougbu dougbu force-pushed the darc-master-17484707-ef29-4596-9109-8676032266de branch from a6295b0 to f3a3559 Compare June 19, 2019 04:54
dougbu
dougbu approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. Will

@dougbu
Copy link
Member

dougbu commented Jun 19, 2019

… rebase on 'master' to (hopefully) clean up timeouts.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 19, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: AspNetCore-helix-test, AspNetCore-ci, AspNetCore-ci (Test: Windows Server 2016 x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling Jun 19, 2019
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor Jun 19, 2019
Update dependencies from https://github.com/aspnet/AspNetCore-Tooling …
b8c7d11 
…build 20190619.3

- Microsoft.NET.Sdk.Razor - 3.0.0-preview7.19319.3
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview7.19319.3
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview7.19319.3
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview7.19319.3
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling Jun 20, 2019
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor Jun 20, 2019
@SteveSandersonMS
Copy link
Member

@dougbu Do you know roughly when we should expect the latest from aspnetcore-tooling to appear in aspnetcore? I'm waiting for the changes in dotnet/razor@6e54900 to reach aspnetcore so I can finish my preview 7 work.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 20, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: AspNetCore-helix-test
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

Update dependencies from https://github.com/aspnet/AspNetCore-Tooling …
886aba3 
…build 20190620.1

- Microsoft.NET.Sdk.Razor - 3.0.0-preview7.19320.1
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview7.19320.1
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview7.19320.1
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview7.19320.1
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling Jun 20, 2019
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor Jun 20, 2019
@dougbu
Copy link
Member

dougbu commented Jun 21, 2019

@SteveSandersonMS feel free to retry AzDO builds and triage build failures to confirm nothing is newly-bad here. I'm not on top of this and likely won't be back at it 'til Monday.

@JunTaoLuo may be able to help or (say) @NTaylorMullen for timezone support from your team.

@dougbu
Copy link
Member

dougbu commented Jun 21, 2019

Actually, I'll review the Helix failures and get this in (I hope). Have a minute…

@dougbu
Copy link
Member

dougbu commented Jun 21, 2019

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=231912

@dougbu
Copy link
Member

dougbu commented Jun 21, 2019

@jkotalik @JunTaoLuo every failing test has .IIS. somewhere in its full name. The tests are failing only on Windows.7.Amd64.Open and Windows.81.Amd64.Open Helix queues. Is this a known issue?

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com.

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2703

@jkotalik
Copy link
Contributor

Hm I thought I was going crazy when identifying why helix was failing. Can you check and see if these tests were failing after the arcade merge? I’m OOF tomorrow so if someone could take a look. I believe it’s an issue with finding dotnet.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 21, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❓ Waiting on checks: AspNetCore-helix-test, AspNetCore-ci, AspNetCore-ci (Test: Templates - Windows Server 2016 x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

Update dependencies from https://github.com/aspnet/AspNetCore-Tooling …
9a0e663 
…build 20190620.3

- Microsoft.NET.Sdk.Razor - 3.0.0-preview7.19320.3
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview7.19320.3
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview7.19320.3
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview7.19320.3
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling Jun 21, 2019
@dougbu
Copy link
Member

dougbu commented Jun 21, 2019

Hm I thought I was going crazy when identifying why helix was failing. Can you check and see if these tests were failing after the arcade merge?

Would be possible to look at the various build start timestamps and compare them to when the Arcade merge went in. But, not something I can do here in a timely fashion.

Separately, has something about these tests changed since the Arcade merge that rerunning would be worthwhile? I'll kick off another build just in case.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 21, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❓ Waiting on checks: AspNetCore-helix-test, AspNetCore-ci, AspNetCore-ci (Test: Templates - Windows Server 2016 x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dougbu
Copy link
Member

dougbu commented Jun 21, 2019

oh already running anew due to another tooling update

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 21, 2019 •
edited
Loading

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: AspNetCore-ci, AspNetCore-ci (Test: Templates - Windows Server 2016 x64), AspNetCore-helix-test, AspNetCore-ci (Test: Ubuntu 16.04 x64), AspNetCore-ci (Test: Windows Server 2016 x64), AspNetCore-ci (Test: macOS 10.13), AspNetCore-ci (Build: Linux Musl x64), AspNetCore-ci (Build: Linux Musl ARM64), AspNetCore-ci (Build: Linux ARM64), AspNetCore-ci (Build: Linux x64), AspNetCore-ci (Build: Linux ARM), AspNetCore-ci (Build: Windows ARM), AspNetCore-ci (Build: macOS), AspNetCore-ci (Build: Windows x64/x86), AspNetCore-ci (Code check)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dougbu dougbu mentioned this pull request Jun 21, 2019
Merged
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor Jun 21, 2019
@SteveSandersonMS SteveSandersonMS mentioned this pull request Jun 21, 2019
Merged
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling Jun 21, 2019
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from aspnet/Blazor aspnet/AspNetCore-Tooling [master] Update dependencies from aspnet/AspNetCore-Tooling aspnet/Blazor Jun 21, 2019
@dotnet-maestro dotnet-maestro bot merged commit edf8bbe into master Jun 21, 2019
@dotnet-maestro dotnet-maestro bot deleted the darc-master-17484707-ef29-4596-9109-8676032266de branch June 21, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dougbu @SteveSandersonMS @aspnet-hello @jkotalik @Eilon