Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable framework tests #13043

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Re-enable framework tests #13043

merged 1 commit into from
Aug 29, 2019

Conversation

JunTaoLuo
Copy link
Contributor

Addresses https://github.com/aspnet/AspNetCore-Internal/issues/2893

Opening up multiple PRs since running multiple isolated builds is a bit slow.

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 12, 2019
@JunTaoLuo JunTaoLuo added the blocked The work on this issue is blocked due to some dependency label Aug 14, 2019
@JunTaoLuo
Copy link
Contributor Author

Blocked on #12977

@JunTaoLuo JunTaoLuo force-pushed the johluo/reenable-framework-tests branch from 3ecd3c7 to a40a02b Compare August 28, 2019 00:27
@JunTaoLuo JunTaoLuo removed the blocked The work on this issue is blocked due to some dependency label Aug 28, 2019
@JunTaoLuo JunTaoLuo marked this pull request as ready for review August 28, 2019 01:27
@JunTaoLuo JunTaoLuo requested a review from a team August 28, 2019 01:28
@dougbu
Copy link
Member

dougbu commented Aug 28, 2019

@JunTaoLuo this isn't blocked anymore 🚀🚀 Validation builds also look good except Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.ResponseTests.ConnectionNotClosedWhenClientSatisfiesMinimumDataRateGivenLargeResponseChunks is failing consistently an all or most Helix platforms.

dougbu
dougbu approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as long as the Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.ResponseTests.ConnectionNotClosedWhenClientSatisfiesMinimumDataRateGivenLargeResponseChunks failures are unrelated. That might have more to do w/ the 5.0 conversion but bears investigation in any case.

@JunTaoLuo
Copy link
Contributor Author

I don't think the test failures are related to this change. Aside from that this change doesn't touch any code paths that would affect the kestrel functional tests, it seems like all helix tests in PRs to master is running into this issue: e.g. https://dev.azure.com/dnceng/public/_build/results?buildId=329235

@JunTaoLuo JunTaoLuo closed this Aug 29, 2019
@JunTaoLuo JunTaoLuo reopened this Aug 29, 2019
@JunTaoLuo
Copy link
Contributor Author

Oops wrong button.

@JunTaoLuo
Copy link
Contributor Author

Test failure is due to flakiness that's being addressed by #13532.

@JunTaoLuo JunTaoLuo merged commit 806fef3 into master Aug 29, 2019
@ghost ghost deleted the johluo/reenable-framework-tests branch August 29, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JunTaoLuo @dougbu @Pilchie