Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferSegment use ArrayPool for over-sized allocs #13495

Merged
merged 2 commits into from
Aug 30, 2019

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Aug 27, 2019

Rather than allocating an array; as per dotnet/corefx#39643

…rHelpers/ConcurrentPipeWriter.cs

Co-Authored-By: David Carr <dvdcrr77@googlemail.com>
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're using the ArrayPool for too-large buffers everywhere else like in StreamPipeWriter, it makes sense for ConcurrentPipeWriter to do the same.

@halter73
Copy link
Member

/azp run AspNetCore-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@halter73
Copy link
Member

The CI failures will hopefully be fixed by #13532

@davidfowl
Copy link
Member

/azp run AspNetCore-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@halter73 halter73 merged commit 9399f09 into dotnet:master Aug 30, 2019
@benaadams benaadams deleted the BufferSegement-ArrayPool branch January 28, 2020 03:57
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants