Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branding to 3.1.0-alpha1 #13521

Closed
wants to merge 5 commits into from
Closed

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Aug 28, 2019

No description provided.

@dougbu dougbu requested a review from a team August 28, 2019 19:20
@dougbu
Copy link
Member Author

dougbu commented Aug 28, 2019

Created as a draft because I expect this to fail without workarounds or (perhaps) using a 'netcoreapp3.1' TFM.

eng/Versions.props Outdated Show resolved Hide resolved
@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 29, 2019
- reverts 3b5a9e5 in this new branch
- no longer needed; these packages can rev with other 3.1 packages
- add `$(TFMNetCoreMajorVersion)` and `$(TFMNetCoreMinorVersion)` properties
- update project template versions
- #13581 part 2 of 3 for this repo
- set property to 'netcoreapp3.1', matching Microsoft.NETCore.App.Ref package layout
@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Sep 13, 2019

Work will be done in #13571. I don't plan on merging the fix for #13937 in this iteration though.

@JunTaoLuo JunTaoLuo closed this Sep 13, 2019
@dougbu dougbu deleted the dougbu/branding.3.1 branch November 22, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants