Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse Http2MessageBody #19629

Merged
merged 4 commits into from Mar 11, 2020
Merged

Reuse Http2MessageBody #19629

merged 4 commits into from Mar 11, 2020

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Mar 6, 2020

Before:
image

After:
image

@ghost ghost added the area-servers label Mar 6, 2020
@JamesNK JamesNK force-pushed the jamesnk/reuse-http2messagebody branch from 5bf2689 to dc45e51 Compare March 10, 2020 01:23
@JamesNK JamesNK added this to the 5.0.0-preview3 milestone Mar 10, 2020
@JamesNK JamesNK merged commit 88b134f into master Mar 11, 2020
@JamesNK JamesNK deleted the jamesnk/reuse-http2messagebody branch March 11, 2020 20:38
Tratcher
Tratcher reviewed Mar 17, 2020
View reviewed changes
src/Servers/Kestrel/Core/src/Internal/Http/MessageBody.cs
@@ -73,6 +73,17 @@ public virtual Task StopAsync()

protected virtual Task OnStopAsync() => Task.CompletedTask;

public virtual void Reset()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to call Reset from the constructor to ensure consistent state the first time it's used.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher left review comments

@halter73 halter73 halter73 approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
5.0.0-preview3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JamesNK @halter73 @Tratcher @amcasey