Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate read and write tx queues #21981

Closed

Conversation

benaadams
Copy link
Member

sendmsg isn't particularly fast so don't have reads queueing behind it

@ghost ghost added the area-servers label May 19, 2020
@benaadams
Copy link
Member Author

@aspnet-hello benchmark json

@pr-benchmarks
Copy link

pr-benchmarks bot commented May 19, 2020

Starting 'json' pipelined plaintext benchmark with session ID 'a6c7ee24a321425fa83169fc47a35816'. This could take up to 30 minutes...

@pr-benchmarks
Copy link

pr-benchmarks bot commented May 19, 2020

Baseline

Starting baseline run on '263c376a80aad6aa7a7fdc3141664a00a1e21eed'...
RequestsPerSecond:           615,231
Max CPU (%):                 99
WorkingSet (MB):             199
Avg. Latency (ms):           3.92
Startup (ms):                458
First Request (ms):          155.12
Latency (ms):                0.29
Total Requests:              9,249,397
Duration: (ms)               15,030
Socket Errors:               0
Bad Responses:               0
Build Time (ms):             20,505
Published Size (KB):         120,819
SDK:                         5.0.100-preview.5.20258.4
Runtime:                     5.0.0-preview.6.20264.1
ASP.NET Core:                5.0.0-preview.5.20255.6


PR

Starting PR run on '01047011cb8451dd7bc47f0cf062f8d8d84af93b'...
| Description |     RPS | CPU (%) | Memory (MB) | Avg. Latency (ms) | Startup (ms) | Build Time (ms) | Published Size (KB) | First Request (ms) | Latency (ms) | Errors | Ratio |
| ----------- | ------- | ------- | ----------- | ----------------- | ------------ | --------------- | ------------------- | ------------------ | ------------ | ------ | ----- |
|      Before | 615,231 |      99 |         199 |              3.92 |          458 |           20505 |              120819 |             155.12 |         0.29 |      0 |  1.00 |
|       After | 579,515 |      99 |         177 |              4.45 |          468 |            5502 |              120819 |             135.47 |         0.35 |     53 |  0.94 |


@benaadams
Copy link
Member Author

@aspnet-hello benchmark json

@pr-benchmarks
Copy link

pr-benchmarks bot commented May 19, 2020

Starting 'json' pipelined plaintext benchmark with session ID '9eb4c44495ad4a6c9bec30d3a262fd0d'. This could take up to 30 minutes...

@pr-benchmarks
Copy link

pr-benchmarks bot commented May 19, 2020

Baseline

Starting baseline run on '263c376a80aad6aa7a7fdc3141664a00a1e21eed'...
RequestsPerSecond:           621,681
Max CPU (%):                 99
WorkingSet (MB):             203
Avg. Latency (ms):           4.01
Startup (ms):                459
First Request (ms):          141.93
Latency (ms):                0.33
Total Requests:              9,342,073
Duration: (ms)               15,030
Socket Errors:               0
Bad Responses:               0
Build Time (ms):             7,502
Published Size (KB):         120,819
SDK:                         5.0.100-preview.5.20258.4
Runtime:                     5.0.0-preview.6.20264.1
ASP.NET Core:                5.0.0-preview.5.20255.6


PR

Starting PR run on '8dbe0d38bc43f5de2844f6ef3d38a79515f3ff95'...
| Description |     RPS | CPU (%) | Memory (MB) | Avg. Latency (ms) | Startup (ms) | Build Time (ms) | Published Size (KB) | First Request (ms) | Latency (ms) | Errors | Ratio |
| ----------- | ------- | ------- | ----------- | ----------------- | ------------ | --------------- | ------------------- | ------------------ | ------------ | ------ | ----- |
|      Before | 621,681 |      99 |         203 |              4.01 |          459 |            7502 |              120819 |             141.93 |         0.33 |      0 |  1.00 |
|       After | 588,340 |      99 |         205 |              4.06 |          463 |            5503 |              120819 |             139.71 |         0.31 |      0 |  0.95 |


@Pilchie Pilchie added the community-contribution Indicates that the PR has been added by a community member label Aug 24, 2020
@BrennanConroy
Copy link
Member

Closing for now.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member Perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants