Change HttpSys default client cert mode to Allow Cert #23162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
added
the
breaking-change
ghost
added
the
halter73
reviewed
Jun 19, 2020
| if (_clientCert == null && method == ClientCertificateMethod.AllowRenegotation) | ||
| { | ||
| _clientCert = await Request.GetClientCertificateAsync(cancellationToken); | ||
| } |
There was a problem hiding this comment.
Why did this method have to change if this PR is merely changing the default mode?
Does this mean that ITlsConnectionFeature.GetClientCertificateAsync() was broken before when ClientCertificateMethod.AllowCertificate was set? Would it previously allow renegotiation anyway? Should we backport this part of the change?
There was a problem hiding this comment.
In the 3.1 fix we were primarily addressing complaints about ClientCertificate triggering IO, and sync-over-async at that. There haven't been complaints about GetClientCertificateAsync, it's rarely used. I'm changing it now more for consistency and efficiency.
halter73
approved these changes
Jun 19, 2020
This was referenced Jun 19, 2020
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14840 TLS Renegotiation causes a number of problems so we added a non-breaking option in 3.1 to let you disable it. Now for 5.0 we're changing it to be disabled by default. I've also updated GetClientCertificateAsync to honor the same setting.
Verified manually, client certs rely on machine state.