Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip conflicting test and re-enable WebHostBuilder test #30672

Merged
merged 2 commits into from
Mar 5, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ public void ActivityOnImportHookIsCalled()
Assert.True(Activity.Current.Recorded);
}

[Fact]
[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/30582")]
public void ActivityListenersAreCalled()
{
var hostingApplication = CreateApplication(out var features);
Expand Down
2 changes: 0 additions & 2 deletions src/Hosting/Hosting/test/WebHostBuilderTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Abstractions;
using Microsoft.Extensions.Logging.Testing;
using Xunit;

[assembly: HostingStartup(typeof(WebHostBuilderTests.TestHostingStartup))]
Expand Down Expand Up @@ -115,7 +114,6 @@ public async Task MultipleUseStartupCallsLastWins(IWebHostBuilder builder)

[Theory]
[MemberData(nameof(DefaultWebHostBuildersWithConfig))]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30582")]
public async Task UseStartupFactoryWorks(IWebHostBuilder builder)
{
void ConfigureServices(IServiceCollection services) { }
Expand Down