Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarantining tests #30702

Merged
merged 4 commits into from
Mar 6, 2021
Merged

Quarantining tests #30702

merged 4 commits into from
Mar 6, 2021

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Mar 5, 2021

@Pilchie Pilchie added area-blazor Includes: Blazor, Razor Components area-servers labels Mar 5, 2021
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#30672 already addresses the hosting issues.

@Tratcher Tratcher requested a review from JunTaoLuo March 5, 2021 21:02
@sebastienros
Copy link
Member Author

@Tratcher is quarantining other tests though

@sebastienros
Copy link
Member Author

And now it's StartupConfigureServicesThrows_Fallback that is also in WebHostBuilderTests that is failing.

@sebastienros
Copy link
Member Author

@JunTaoLuo so it's a side effect of the other test that you are disabled? I will remove this then, I understand what you meant now @Tratcher.

@Tratcher Tratcher dismissed their stale review March 5, 2021 21:55

Addressed

@sebastienros sebastienros merged commit 23c6469 into main Mar 6, 2021
@sebastienros sebastienros deleted the sebros/qtn branch March 6, 2021 03:07
@shirhatti
Copy link
Contributor

I don't enough about how we quarantine tests, but in this instance the test was failing due to shared global state in the process. I assume after quarantining, the test now runs in a separate process, making it unlikely to ever fail while quarantined 😄

I'll file a work item to make our Activity tests more resilient by preferably moving them into a separate process.

@ghost
Copy link

ghost commented Mar 7, 2021

Hi @shirhatti. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@Tratcher
Copy link
Member

Tratcher commented Mar 7, 2021

I don't enough about how we quarantine tests, but in this instance the test was failing due to shared global state in the process. I assume after quarantining, the test now runs in a separate process, making it unlikely to ever fail while quarantined 😄

Not quite. I think quarantined tests are skipped in normal runs but run normally in our special quarantine build. Quarantine is inadequate for tests that can cause side-effects for other tests.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants