-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.1] Mark components assemblies as non shipping #31758
Conversation
@@ -6,7 +6,7 @@ | |||
<PackageTags>wasm;javascript;interop</PackageTags> | |||
<GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
<IsPackable>true</IsPackable> | |||
<IsShipping>true</IsShipping> | |||
<IsShipping>false</IsShipping> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougbu is this the same as IsShippingPackage ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of. The Arcade turns one into the other at https://github.com/dotnet/arcade/blob/e7ede87875f41a9b3df898ae08da5ebc96e24f56/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L22
No, branches are closed down for May. We should hold this until next month's check-in window |
nit: @HaoK could you please use the GitHub UI features to make a bunch of suggestions in a comment, then batch committing those suggestions together❔ That'll take us from 15 emails to 2 when we're on your PRs 😀 |
Follow up to #28492
Also mark WebAssembly packages as non shipping