Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging internal commits for release/5.0 #33376

Merged
merged 12 commits into from
Jun 8, 2021
Merged

Merging internal commits for release/5.0 #33376

merged 12 commits into from
Jun 8, 2021

Conversation

vseanreesermsft
Copy link
Contributor

No description provided.

dotnet-bot and others added 9 commits May 4, 2021 21:36
@dotnet-bot
Merge in 'release/5.0' changes
c257304
@dotnet-bot
Merge in 'release/5.0' changes
5d8e736
@dotnet-bot
[internal/release/5.0] Update dependencies from dnceng/internal/dotne…
821b46f 
…t-runtime
@dotnet-bot
Merge in 'release/5.0' changes
8cddac6
@dotnet-bot
Merge in 'release/5.0' changes
6842f90
@jkotalik
Merged PR 14745: Call RaiseEvent later
3567768 
For 5.0
@dotnet-bot @mmitche
Merged PR 14945: [internal/release/5.0] Update dependencies from dnce…
35b0a3d 
…ng/internal/dotnet-runtime

This pull request updates the following dependencies

[marker]: <> (Begin:d7d10d70-26ab-4663-2902-08d89c6af29b)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: d7d10d70-26ab-4663-2902-08d89c6af29b
- **Build**: 20210505.8
- **Date Produced**: 5/5/2021 10:27 PM
- **Commit**: 556582d964cc21b82a88d7154e915076f6f9008e
- **Branch**: refs/heads/internal/release/5.0

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.NETCore.App.Internal**: [from 5.0.7-servicing.21255.4 to 5.0.7-servicing.21255.8][1]
  - **Microsoft.NETCore.App.Runtime.win-x64**: [from 5.0.7 to 5.0.7][1]
  - **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 5.0.7-servicing.21255.4 to 5.0.7-servicing.21255.8][1]

[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC6701b31&targetVersion=GC556582d&_a=files

[DependencyUpdate]: <> (End)

[marker]: <> (End:d7d10d70-26ab-4663-2902-08d89c6af29b)
@dotnet-bot
[internal/release/5.0] Update dependencies from dnceng/internal/dotne…
67acc3d 
…t-efcore
@vseanreesermsft
Merge commit '67acc3d331454956fc06d6de2218a625e3e596f8' into internal…
456ee16 
…-merge-5.0-2021-06-08-1100
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 8, 2021
dougbu
dougbu approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/fyi @dotnet/aspnet-build

@dougbu
Copy link
Member

dougbu commented Jun 8, 2021

@vseanreesermsft @mmitche @wtgodbe can these PRs be opened using branches in the target repo instead of a fork❔ The permissions were fine but it's a stumbling block to switch gears from git pull origin / git push origin when it's pretty much only external contributors using forks.

@dougbu dougbu added Type: Merge Forward ⏩ area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-runtime labels Jun 8, 2021
@mmitche
Copy link
Member

mmitche commented Jun 8, 2021

@vseanreesermsft @mmitche @wtgodbe can these PRs be opened using branches in the target repo instead of a fork❔ The permissions were fine but it's a stumbling block to switch gears from git pull origin / git push origin when it's pretty much only external contributors using forks.

At the very least it shouldn't be using a personal fork. But I think it should be using a fork from a security standpoint.

@dougbu dougbu merged commit 5f66295 into dotnet:release/5.0 Jun 8, 2021
@dougbu dougbu added this to the 5.0.8 milestone Jul 6, 2021
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 6, 2021
@ghost ghost added this to Tell Mode in Servicing Status Jul 6, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher Tratcher is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member tell-mode Indicates a PR which is being merged during tell-mode Type: Merge Forward ⏩
Projects
No open projects
Servicing Status
  
Tell Mode
Milestone
5.0.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vseanreesermsft @dougbu @mmitche @amcasey @dotnet-bot @jkotalik