Include source in RequestDelegateFactory missing required parameter log #35580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
requested review from
davidfowl,
captainsafia and
rafikiassumani-msft
ghost
added
the
captainsafia
approved these changes
Aug 25, 2021
| @@ -219,17 +219,17 @@ private static Expression CreateArgument(ParameterInfo parameter, FactoryContext | |||
| throw new InvalidOperationException($"{parameter.Name} is not a route paramter."); | |||
| } | |||
|
|
|||
| return BindParameterFromProperty(parameter, RouteValuesExpr, routeAttribute.Name ?? parameter.Name, factoryContext); | |||
| return BindParameterFromProperty(parameter, RouteValuesExpr, routeAttribute.Name ?? parameter.Name, factoryContext, "route"); | |||
There was a problem hiding this comment.
Super nit: can we move these string literals to constants or something?
|
Closing in favor of #36004 which includes these changes. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #30322