Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't exclude System.IO.Pipelines from TargetingPack version check #39287

Merged
merged 1 commit into from Jan 4, 2022
Merged

Don't exclude System.IO.Pipelines from TargetingPack version check #39287

merged 1 commit into from Jan 4, 2022

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 3, 2022

First part of #31074. Also check that Version.Build == 0 in addition to Version.Revision

@wtgodbe wtgodbe requested a review from a team January 3, 2022 23:08
@wtgodbe wtgodbe requested a review from Pilchie as a code owner January 3, 2022 23:08
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 3, 2022
dougbu
dougbu reviewed Jan 4, 2022
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, great❕

Does this change imply we no longer have incoming assemblies w/ versions that aren't like 7.0.0.0❔

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 4, 2022

Does this change imply we no longer have incoming assemblies w/ versions that aren't like 7.0.0.0❔

That's what I saw locally

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 4, 2022

@dougbu you alright with this change?

@dougbu
Copy link
Member

dougbu commented Jan 4, 2022

you alright with this change?

Yes, I meant to approve the PR yesterday ☹️

@wtgodbe wtgodbe merged commit 1e26857 into dotnet:main Jan 4, 2022
@ghost ghost added this to the 7.0-preview1 milestone Jan 4, 2022
@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 4, 2022

/backport to release/6.0

@wtgodbe wtgodbe deleted the wtgodbe/VersionTestingSfx branch January 4, 2022 17:27
@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 4, 2022

/backport to release/5.0

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1654775269

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/1654776113

This was referenced Jan 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wtgodbe @dougbu