New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Use TimeSpan.FromMilliseconds for clientTimeoutInterval in ClientTime… #39325
Conversation
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
@BrennanConroy is this PR waiting for something❔ |
Yes, I didn't know it was servicing approved until just now (you don't get notified when a label or milestone is added/changed). @halter73 could you give this a quick review? |
We should probably rename these variables to include |
Build won't pass until 1ES provider is fixed and I get #39364 in. Will need to repeat validation. So, I canceled the current build. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
All set for squish and munge @BrennanConroy❔ |
Yes |
Backport of #39318 to release/6.0
/cc @BrennanConroy @campersau
Description
In 6.0 we refactored some code with timeouts and didn't update a log message so it now displays the wrong timeout value.
Fixes #39171
Customer Impact
When looking at logs for why a connection closed, you will see the incorrect value for how long a timeout occurred. For example, a 90 second timeout will be logged as 9 milliseconds.
Customer reported issue at #39171
Regression?
Regressed from 5.0 to 6.0
Risk
Just changing the units of a value in a log message.
Verification
Packaging changes reviewed?