Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing runtime-extension-internal.zip #3984

Merged
merged 5 commits into from Nov 9, 2018

Conversation

natemcmaster
Copy link
Contributor

Neither of these zips are used anymore, and they currently fail sign checks because they were not configure to run through SignTool.

@jkotalik
Copy link
Contributor

jkotalik commented Nov 8, 2018

StressTestWebsite.zip is still used (we upload it to IIS Stress Test Infra). Can we still build StressTestWebsite.zip, but keep it in a bin folder next to the stress test site as we don't need to sign it?

@natemcmaster
Copy link
Contributor Author

Oh, I was misinformed then. Who uploads this and when? I couldn't find anything in our build drops or CI config for this.

@jkotalik
Copy link
Contributor

jkotalik commented Nov 8, 2018

We have to manually upload it unfortunately because we can't access corpnet through VSTS. Hence, we can probably just create a zip file in a bin folder instead of artifacts.

@natemcmaster
Copy link
Contributor Author

Okay, I'm going to change the output path for this zip so it goes to artifacts/testassets/

@natemcmaster natemcmaster changed the title Stop producing StressTestWebsite.zip and publishing runtime-extension-internal.zip Stop publishing runtime-extension-internal.zip Nov 9, 2018
Copy link
Contributor

@jkotalik jkotalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes for runtime-extension-internal.zip, did you revert them accidentally?

@natemcmaster
Copy link
Contributor Author

Oops, re-reverted

@natemcmaster
Copy link
Contributor Author

🆙 📅

Chatted in person. We'll leave the /t:PackageStressTestApp target, but remove it from running by default on CI since we normally only upload local builds anyways into our internal stress test infrastructure.

@natemcmaster natemcmaster merged commit ba70991 into release/2.2 Nov 9, 2018
@natemcmaster natemcmaster deleted the namc/rm-oob-zips branch November 9, 2018 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants