Consume HostApplicationBuilder from WebApplicationBuilder #40459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
davidfowl
reviewed
Mar 1, 2022
|
|
||
| Properties = properties; | ||
| foreach (var descriptor in _builder.Services) |
There was a problem hiding this comment.
I thought the goal was to remove the hacks...
There was a problem hiding this comment.
I hope to propose a better public API than ConfigureWebHostDefaults to consume the default configuration from Microsoft.Extensions.Hosting in Microsoft.AspNetCore, but that will likely have a big surface area that will need API reviewed. I think this can be done as a follow up.
halter73
force-pushed
the
halter73/61634
branch
from
3ce0067
to
680bf2a
Compare
davidfowl
reviewed
Mar 18, 2022
Tratcher
approved these changes
Mar 18, 2022
halter73
force-pushed
the
halter73/61634
branch
from
5b1a369
to
ac89341
Compare
davidfowl
approved these changes
Mar 18, 2022
1 task
1 task
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on dotnet/runtime#65109 being merged and a subsequent arcade dependency update from the runtime repo.
I hope to propose a better public API than
ConfigureWebHostDefaults(#40761) to consume the default configuration from Microsoft.Extensions.Hosting in Microsoft.AspNetCore, but that will likely have a big surface area that will need API reviewed. I think this can be done as a follow up.