Introducing I*HttpResult interfaces
#42385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
brunolins16
requested review from
Tratcher,
BrennanConroy and
halter73
as code owners
davidfowl
reviewed
Jun 29, 2022
src/Http/Http.Abstractions/src/HttpResults/IContentTypeHttpResult.cs
Outdated
Show resolved
Hide resolved
…ult.cs Co-authored-by: Martin Costello <martin@martincostello.com>
|
|
||
| /// <summary> | ||
| /// Defines a contract that represents the result of an HTTP endpoint | ||
| /// that contains a nested <see cref="IResult"/> type. |
There was a problem hiding this comment.
Maybe add a remark about the Result<T1, T2> type?
| @@ -37,7 +41,7 @@ internal ProblemHttpResult(ProblemDetails problemDetails) | |||
| /// <summary> | |||
| /// Gets the HTTP status code. | |||
| /// </summary> | |||
| public int? StatusCode => ProblemDetails.Status; | |||
| public int StatusCode => ProblemDetails.Status!.Value; | |||
There was a problem hiding this comment.
Should we check for null and use a default status code?
There was a problem hiding this comment.
We set the default in the constructor, and it will not be null
But sure, I can add a check if you prefer.
BrennanConroy
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #42187