Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarantine ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCi… #44018

Merged
merged 2 commits into from Sep 16, 2022
Merged

Quarantine ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCi… #44018

merged 2 commits into from Sep 16, 2022

Conversation

brunolins16
Copy link
Member

Addresses #44017

@brunolins16 brunolins16 requested a review from a team as a code owner September 15, 2022 21:46
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Sep 15, 2022
mkArtakMSFT
mkArtakMSFT approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brunolins16!

TanayParikh
TanayParikh suggested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we want to auto-retry these tests first: https://github.com/dotnet/aspnetcore/blob/main/eng/test-configuration.json#L5

https://github.com/dotnet/aspnetcore-internal/blob/main/docs/operations/quarantine_tests.md#instructions

@brunolins16
Copy link
Member Author

I believe we want to auto-retry these tests first: https://github.com/dotnet/aspnetcore/blob/main/eng/test-configuration.json#L5

https://github.com/dotnet/aspnetcore-internal/blob/main/docs/operations/quarantine_tests.md#instructions

They are not in helix. I think we need quarantine in this case.

TanayParikh
TanayParikh approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, thanks!

@brunolins16 brunolins16 merged commit 710da77 into main Sep 16, 2022
@brunolins16 brunolins16 deleted the brunolins16/buildops/quarantine/ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCircuit branch September 16, 2022 04:50
@ghost ghost added this to the 8.0-preview1 milestone Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanayParikh TanayParikh TanayParikh approved these changes

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brunolins16 @TanayParikh @mkArtakMSFT