Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Add support for minimal APIs in ApiDescription.Server #44227

Merged
merged 3 commits into from Oct 4, 2022
Merged

[release/6.0] Add support for minimal APIs in ApiDescription.Server #44227

merged 3 commits into from Oct 4, 2022

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Sep 28, 2022 •
edited

Description

This PR update the dotnet getdocument tool to react to changes in hosting that were shipped in .NET 6.

The hosting changes were incongruent with the strategy that the getdocument tool used to extract the active ServiceProvider from the application assembly.

This is a backport of a fix that was released in NET 7.0.

Closes #44215

Customer Impact

Without this change, OpenAPI document generation in the CLI and client generation in Visual Studio would fail to produce the necessary schemas and code for minimal API endpoints in user applications.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Low because:

  • Change is limited to getdocument tool
  • Change follows pattern used to react to hosting changes in other apps that examine host

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Sep 28, 2022
@ghost ghost added this to the 6.0.x milestone Sep 28, 2022
@ghost ghost added this to In Progress in Servicing Sep 28, 2022
@ghost
Copy link

ghost commented Sep 28, 2022

Hi @captainsafia. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@captainsafia captainsafia added the Servicing-consider Shiproom approval is required for the issue label Sep 28, 2022
@ghost
Copy link

ghost commented Sep 28, 2022

Hi @captainsafia. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@rbhanda rbhanda added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 29, 2022
@rbhanda rbhanda modified the milestones: 6.0.x, 6.0.11 Sep 29, 2022
@captainsafia captainsafia marked this pull request as ready for review September 29, 2022 17:31
@captainsafia captainsafia requested review from a team and dougbu September 29, 2022 17:31
@dougbu
Copy link
Member

dougbu commented Sep 29, 2022

Suggest cherry-picking b6d995a into your branch @captainsafia. ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCircuit() is quarantined in both release/7.0 and main. Looks like it should be quarantined in release/6.0 too.

dougbu
dougbu approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note branches are not currently open

@captainsafia captainsafia mentioned this pull request Sep 29, 2022
Closed
1 task
@dougbu @captainsafia
[release/7.0] Quarantine `ClosingTheBrowserWindow_GracefullyDisconnec…
fa53779 
…ts_TheCurrentCircuit` (#44186)

- #44185
- also upload test logs for forks
@captainsafia captainsafia requested review from a team as code owners September 29, 2022 18:49
@captainsafia
Copy link
Member Author

captainsafia commented Sep 29, 2022 •
edited

Suggest cherry-picking b6d995a into your branch @captainsafia. ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCircuit() is quarantined in both release/7.0 and main. Looks like it should be quarantined in release/6.0 too.

Done!

Note branches are not currently open

Yep -- just getting it teed up since it came up recently.

@wtgodbe wtgodbe merged commit 08072a8 into release/6.0 Oct 4, 2022
Servicing automation moved this from In Progress to Done Oct 4, 2022
@wtgodbe wtgodbe deleted the safia/bp-apidesc-fix-6.0 branch October 4, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI Servicing-approved Shiproom has approved the issue
Projects
Servicing
Done
Milestone
6.0.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@captainsafia @dougbu @wtgodbe @rbhanda